Skip to content

[23365] Use has_more_replies field when sending output feed values#488

Merged
MiguelCompany merged 1 commit into
masterfrom
feature/extend-related-sample-identity
Jul 2, 2025
Merged

[23365] Use has_more_replies field when sending output feed values#488
MiguelCompany merged 1 commit into
masterfrom
feature/extend-related-sample-identity

Conversation

@MiguelCompany

@MiguelCompany MiguelCompany commented Jun 23, 2025 •
edited by Mario-DL
Loading

Copy link
Copy Markdown
Member

Description

Sets the new has_more_replies field when sending values of an output feed.

This PR depends on the following PR and must be merged after:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany
MiguelCompany requested review from richiprosima and removed request for richiprosima June 23, 2025 12:08
@github-actions github-actions Bot added the ci-pending PR which CI is running label Jun 23, 2025
@MiguelCompany MiguelCompany added this to the v4.1.0 milestone Jun 24, 2025
Mario-DL
Mario-DL reviewed Jun 26, 2025
View reviewed changes

@Mario-DL Mario-DL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not approving since IDK if we are including any test here

@MiguelCompany
Refs #23365. Use has_more_replies field when sending output feed va…
0e44827 
…lues.

Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
@MiguelCompany
MiguelCompany force-pushed the feature/extend-related-sample-identity branch from fcb231b to 0e44827 Compare June 30, 2025 14:51
@MiguelCompany
MiguelCompany requested a review from Mario-DL July 1, 2025 15:17
@MiguelCompany MiguelCompany mentioned this pull request Jul 1, 2025
Merged
7 tasks
@MiguelCompany
MiguelCompany merged commit 0c2745d into master Jul 2, 2025
4 checks passed
@MiguelCompany
MiguelCompany deleted the feature/extend-related-sample-identity branch July 2, 2025 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Mario-DL Mario-DL Mario-DL approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci-pending PR which CI is running

Projects

None yet

Milestone

v4.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@MiguelCompany @Mario-DL